remove root assignment in stringifier #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the deep investigation. Yeap, it was just a typo, which causes a bug in a rare case. I will release it a few hours later after lunch. |
|
Thanks a lot for the quick turnaround. This'll allow us to use postcss inside web components a lot easier, so I'm sure it'll make plenty of people happy. |
|
Do you have Twitter account to mention you in release tweet? |
|
Sure, I've been tweeting about this stuff for a few days now myself haha. You can find me at @43081j the same as here |
|
Released in 8.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1494
I had a search around your codebase and it doesn't look like anything used
Stringifier#rootas a property. so i just removed the line. if you'd rather have it renamed, let me knowit was overwriting the
root(node)method previously, which was clearly wrong and caused issues with nested roots.cc @ai