Fixup JSON AST conversion #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai
reviewed
Dec 9, 2020
ai
reviewed
Dec 9, 2020
ai
reviewed
Dec 9, 2020
|
|
mischnic
force-pushed
the
fixup-fromJSON
branch
from
c50d685
to
d013915
Compare
Should that function also delete the |
Yeap. Send PR. I will release it. |
mischnic
force-pushed
the
fixup-fromJSON
branch
from
d013915
to
8a4ae33
Compare
|
Are we ready to release it? |
|
I've just tested this in my project and it seems to work now |
|
BTW, why do you need JSON AST rehydration? |
|
For Parcel, I want to send ASTs across worker threads/cache them to disk. Thanks you so much for the fast process! |
|
Released in 8.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found two problems related to
Input:1std and 2nd commit: I missed that all nodes have a
sourceproperty, not just the root (this caused stringification to fail)3rd commit: More of an optimization: because of 1), the source contents & map would be stored once for every node (!). This has something like a quadratic memory usage because larger CSS files have more files, so with 10x more rules, the CSS source is about 10x larger and is stored 10x times.
I've instead deduplicated these inputs objects by replacing
node.source.inputwith a number in thetoJSONoutput and including a_inputsarray which maps number to input object (because most of these are===-equal). This is then reversed in fromJSON. This breaks a buch ofpostcss-parser-teststests at the moment though. What do you think of this approach? (Before I try to adjust the parser test runner to accept this version...)