Replace line-column with vfile-location #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfile-location is dependency free and quite fresh package. https://github.com/vfile/vfile-location line-column has outdated dependencies and was not touched in 5 years. https://github.com/io-monad/line-column
ai
reviewed
Nov 21, 2020
lib/input.d.ts
Outdated
| fromOffset (offset: number): { line: number; col: number } | null | ||
| fromOffset ( | ||
| offset: number | ||
| ): { offset?: number; line?: number; column?: number } |
There was a problem hiding this comment.
We can’t change public API. Let’s convert object.
TrySound
commented
Nov 21, 2020
| let position = finder.toPoint(i) | ||
| return { | ||
| line: position.line, | ||
| col: position.column |
There was a problem hiding this comment.
Maybe add TODO here to make api consistent in v9?
|
LGTM. Will release it a few hours later. |
|
Released in 8.1.9. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vfile-location is dependency free and quite fresh package.
https://github.com/vfile/vfile-location
line-column has outdated dependencies and was not touched in 5 years.
https://github.com/io-monad/line-column