fix(typescript): ensure LazyResult complies with Promise interface. #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai
reviewed
Nov 18, 2020
ai
reviewed
Nov 18, 2020
| const processResult: Promise<Result> | Result = postcss([ | ||
| plugin | ||
| ]).process('h1{color: black;}', { from: undefined }) | ||
| const processed: |
There was a problem hiding this comment.
Why we can use processed: Result = here?
There was a problem hiding this comment.
Sorry I am not sure I understand the question. I don't think processed can be of type result since I am mapping it to a different object in then(). If you want I can simplify this example, it actually comes from a real-life sample in the Vue.js 3 repo).
ludofischer
force-pushed
the
fix-lazyresult-type
branch
from
34d765d
to
15feb8f
Compare
* Explicitly implement Promise<Result> in the type declaration * Add mising [Symbol.toStringTag] property * Add some type tests to ensure we can type `postcss(plugins).process` results
ludofischer
force-pushed
the
fix-lazyresult-type
branch
from
15feb8f
to
362ac8d
Compare
|
Thanks. Released in 8.1.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, following our Gitter chat yesterday, I've learnt
LazyResultwas meant to implement thePromisecontract. This pull request adds the [Symbol.toStringTag] property toLazyResultwhich Typescript requires to type something as aPromise.postcss(plugins).processresults