Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade source-map to 0.7.2 to get speed improvements #1126

Closed
andreicristianpetcu opened this issue Mar 4, 2018 · 2 comments
Closed

Comments

@andreicristianpetcu
Copy link

The latest source-map which is v0.7.2 got support for WebAssembly and it is 10 times faster than the old one. More info here:

https://github.com/mozilla/source-map/blob/master/CHANGELOG.md#072
http://fitzgeraldnick.com/2018/02/26/speed-without-wizardry.html
https://hacks.mozilla.org/2018/01/oxidizing-source-maps-with-rust-and-webassembly/
firefox-devtools/debugger#5598

Please update so you would get 10 times speed improvements for your library in Firefox, 9 times in Safari and 5 times in Chrome.

@ai
Copy link
Member

ai commented Mar 5, 2018

Since source-map uses async API we can't update it without major release (with a lot of changes).

Or maybe I understood something wrong?

@ai ai added the enhancement label Mar 17, 2018
@ai ai added this to the 7.0 milestone Mar 17, 2018
@ai
Copy link
Member

ai commented Jun 21, 2018

I tried to add it in 7.0, but found few big problems.

  • The minor problem is that new WASM source-map uses async API. It is not a problem in stringifier. But we need source map reading in Node#error. Moving this method to async will break too many plugins.
  • The main problem is that WASM is supported (if I understand it correctly) only from Node.js 8. We need to support Node.js 6 until April 2019.
  • source map is not the main performance problem in most PostCSS use cases.

In result of this reasons, I decide to wait for a little until source-map update (it is painful for me too, I really like to use the latest software 😭). We will wait until:

@ai ai closed this as completed Jun 21, 2018
@ai ai removed this from the 7.0 milestone Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants