Fix nested tail ampersands #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’d prefer the original version, but I understand why it doesn’t work atm and see no non-hackish way to change it
|
LGTM. I will merge it after lunch. |
|
Released in 5.0.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #115. It’s a much deeper change than I would have liked, but I see no other way to fix the issue.
In order for tail ampersands (
a & {…}) to be replaced correctly, we need to know the parent’s full selector before we can replace the&. Therefore we need to do the replacements on the way down (inRule) instead of on the way up (inRuleExit).This has all sorts of implications for plugin execution order. I needed to change how @-rules are handled to make the pre-existing
it works with other visitorstest pass. Otherwise, the fix for the&rules would have changed the order of rule declarations in the resulting CSS.All the existing tests still pass (except for one whitespace issue; see the last commit) and I’ve added a bunch more to make sure, but you should probably still consider flagging this fix as a breaking change.