Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for postcss v8 #432

Merged
merged 3 commits into from Oct 13, 2020
Merged

added support for postcss v8 #432

merged 3 commits into from Oct 13, 2020

Conversation

oscarotero
Copy link
Contributor

@oscarotero oscarotero commented Oct 4, 2020

Fixes #427
Supersedes #428

I did this changes following the plugin migration guide (https://evilmartians.com/chronicles/postcss-8-plugin-migration). I hope it helps.

@oscarotero oscarotero mentioned this pull request Oct 4, 2020
@oscarotero
Copy link
Contributor Author

I'm having the same CI errors than the previous PR. These errors are related with the source-map generation in windows (it seems like is about the directory separation).

@RyanZim
Copy link
Collaborator

RyanZim commented Oct 5, 2020

@oscarotero Looks like it's just a paths issue, there's an HTML file in test/sourcemap to actually test the sourcemaps in your browser devtools; if the sourcemap is working fine, you can just update the expected result in the tests to get them passing.

@oscarotero
Copy link
Contributor Author

I had to create a different sourcemap for windows to pass the tests, but it's working.

@RyanZim
Copy link
Collaborator

RyanZim commented Oct 6, 2020

@oscarotero Were you able to verify that the sourcemap generated on Windows works correctly on Windows? If not, that's fine, just curious.

@oscarotero
Copy link
Contributor Author

@RyanZim No, I don't have any Windows machine to verify that 😅

@bytestream
Copy link

@RyanZim Anything I can help with to get this merged?

@RyanZim RyanZim merged commit c5679db into postcss:master Oct 13, 2020
@RyanZim
Copy link
Collaborator

RyanZim commented Oct 13, 2020

Merged, need to do some other dependency upgrades before I release, but hopefully should be out this week.

@RyanZim
Copy link
Collaborator

RyanZim commented Oct 21, 2020

Sorry so long, finally released in v13 yesterday 🎉

@bytestream
Copy link

Thanks man 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with PostCSS 8
3 participants