Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for :
Before this change a data url would throw an error, so this is not something that is being used today by users of this plugin.
As far as I can tell the change required is minimal and everything just works.
I don't this is useful on its own.
Authors should not be base64 encoding CSS source code and storing this in
@import
urls.It can however be useful for other plugins that have non-standard interactions with
@import
.Another plugin that does want to provide extra features can choose to store as base64 instead of inlining.
This keeps the source valid with all
@import
rules before anything else and all in the correct order.An alternative approach to this is that other plugins use the file system.
Instead of inlining they can store the contents in a file and update the
@import
rules so they each is fully standard CSS and everything points to a local file.Both approaches have merit and I don't have a strong preference between them.