Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve layer in ignored @imports statements #511

Merged

Conversation

romainmenke
Copy link
Collaborator

@romainmenke romainmenke commented Dec 1, 2022

fix : #510

  • preserves layer when writing @import rules
  • correctly "concats" layers for @import rules

@argyleink Can you also take a look at this?

@romainmenke romainmenke changed the title fix : #510 preserve layer in ingored @imports statements Dec 1, 2022
@romainmenke romainmenke changed the title preserve layer in ingored @imports statements preserve layer in ignored @imports statements Dec 1, 2022
Copy link

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didnt run the code and inspect anything with a debugger, but overall the test cases added cover the issue and the plugin code changes look minimal but corrective. LGTM 👍🏻

Comment on lines +15 to +18
@import "http://css" layer;
@import "http://css" layer(bar);
@import "http://css" layer screen and (min-width: 25em), print;
@import "http://css" layer(bar) screen and (min-width: 25em), print;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘🏻

@RyanZim RyanZim merged commit 2780457 into postcss:master Dec 1, 2022
@romainmenke romainmenke deleted the fix-510--intuitive-marsh-frog-debb5d1d54 branch December 1, 2022 18:39
@RyanZim RyanZim added the bug label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin is stripping the layer off of a remote url import
3 participants