Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove postcss imports #455

Closed
oscarotero opened this issue May 6, 2021 · 2 comments · Fixed by #456
Closed

Remove postcss imports #455

oscarotero opened this issue May 6, 2021 · 2 comments · Fixed by #456

Comments

@oscarotero
Copy link
Contributor

According to migration guide, the Step 4 recomends to remove the postcss imports and use the second argument of the Root function.

This is not the case of process-content.js file: https://github.com/postcss/postcss-import/blob/master/lib/process-content.js#L7

I think the processContent function should have another argument for that, in order to remove the direct import. This would be very helpful for the Deno version, to avoid loading two different versions of postcss.

@RyanZim
Copy link
Collaborator

RyanZim commented May 6, 2021

Agreed, PR welcome.

@oscarotero
Copy link
Contributor Author

Done!

RyanZim pushed a commit that referenced this issue May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants