Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails silently when config not found #467

Open
kkmuffme opened this issue Jan 1, 2024 · 1 comment · May be fixed by #471
Open

Fails silently when config not found #467

kkmuffme opened this issue Jan 1, 2024 · 1 comment · May be fixed by #471

Comments

@kkmuffme
Copy link

kkmuffme commented Jan 1, 2024

When the config file isn't found, it silently fails and does nothing:
b5a0c4f

Is there a specific reason why this error is ignored @RyanZim ?

Would you accept a PR that changes this behavior that if a config path is passed (but no config found), it will still throw an error?

@RyanZim
Copy link
Collaborator

RyanZim commented Jan 3, 2024

It's ignored since a config file isn't required (e.g. you could pass plugins inline with -u). However, it would make sense to throw if the --config option is being used, but no config file is found; PR welcome. Fair warning, this will be a breaking change, which I'd prefer to bundle with other breaking upgrades, so it probably won't be released right away.

kkmuffme added a commit to kkmuffme/postcss-cli that referenced this issue Jan 16, 2024
@kkmuffme kkmuffme linked a pull request Jan 16, 2024 that will close this issue
kkmuffme added a commit to kkmuffme/postcss-cli that referenced this issue Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants