Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix map file path creation #286

Merged
merged 4 commits into from Jul 8, 2019
Merged

Fix map file path creation #286

merged 4 commits into from Jul 8, 2019

Conversation

bcomnes
Copy link
Contributor

@bcomnes bcomnes commented Jul 6, 2019

Closes #283

I wrote a failing test and then implemented a similar version that works.

@bcomnes bcomnes changed the title Add failing test for external map file path creation Fix map file path creation Jul 6, 2019
bcomnes
bcomnes commented Jul 6, 2019
View reviewed changes
lib/getMapfile.js Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jul 6, 2019 •
edited

Coverage Status

Coverage increased (+0.5%) to 75.839% when pulling ee41093 on bcomnes:fix-external-map-bug into f1c7352 on postcss:master.

@bcomnes bcomnes mentioned this pull request Jul 6, 2019
Closed
@RyanZim RyanZim merged commit 0de7ccf into postcss:master Jul 8, 2019
@RyanZim
Copy link
Collaborator

RyanZim commented Jul 8, 2019

Released in v6.1.3 🎉 Sorry for the slow merge, was on vacation.

@bcomnes bcomnes deleted the fix-external-map-bug branch July 8, 2019 18:00
@bcomnes
Copy link
Contributor Author

bcomnes commented Jul 8, 2019

Woo! Slow merge? That was fast :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanZim RyanZim RyanZim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Having a .css in the directory path breaks external source map paths
3 participants
@bcomnes @coveralls @RyanZim