Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release? #100

Closed
jasminexie opened this issue Oct 23, 2019 · 8 comments
Closed

New release? #100

jasminexie opened this issue Oct 23, 2019 · 8 comments

Comments

@jasminexie
Copy link
Contributor

Hi! I'm using postcss-calc in one of my company projects, and we've encountered a few issues with the parser, most of which were related to custom properties, like (#77, #91). I found that these have been fixed in the recent refactor, but the patch has not been released.

This is an important fix for many users, so I am curious as to when there will be a release. Thank you!

@alexander-akait
Copy link
Collaborator

@jasminexie hi, in my todo list, a lot of work and nobody want to help

@jasminexie
Copy link
Contributor Author

@jasminexie hi, in my todo list, a lot of work and nobody want to help

Thank you for the hard work on this repo. If there's anything the community can do I'll be happy to help. I'll be watching this for updates.

@alexander-akait
Copy link
Collaborator

@jasminexie we have other bugs https://github.com/postcss/postcss-calc/issues, feel free to pick up any and send a PR

@jasminexie
Copy link
Contributor Author

Hi, I've looked through the issues and run a few tests with the current master branch. #91, #89, #77 are all fixed with the recent refactor.

I've run a local test with the latest master of postcss-calc and the latest version of postcss-custom-variables. #87 reduces correctly, and I believe is fixed.

Most of the issues mentioned above already have test cases covering them, but I can add more tests if necessary.

I don't think #92 is a bug, and the remaining open issues (#67 and #62) are all feature requests. There is an open PR for #62 that needs to be rebased against the latest master.

In short, I don't think the current master branch has any other reported bugs. Unless you're waiting for feature PRs, I believe this project is ready for a release. 😄

@alexander-akait
Copy link
Collaborator

@jamiebuilds Thanks

@alexander-akait
Copy link
Collaborator

Please look here cssnano/cssnano#833, postcss-calc is part of cssnano

@alecmarcus
Copy link

I've run into #87, but commenting here because it seems more relevant. Is there anything stopping the next release from master? Would be great to have the fix for all these issues. Anything I can do to help?

@Semigradsky
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants