Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump postcss version to 8 #162

Merged
merged 7 commits into from Sep 23, 2020

Conversation

m4thieulavoie
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Sep 15, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling c0519ac on m4thieulavoie:chore/postcss-major-bump into 5f92ee0 on postcss:master.

@m4thieulavoie
Copy link
Contributor Author

Could use some eyes on this @ai @w0rm

@ai
Copy link
Member

ai commented Sep 15, 2020

You need to do a few extra steps

#161

@m4thieulavoie
Copy link
Contributor Author

You need to do a few extra steps

#161

Done, I hope it's okay this way 😄

README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@ai
Copy link
Member

ai commented Sep 17, 2020

I released postcss-load-config 2.1.1. Can you update it in PR?

@m4thieulavoie
Copy link
Contributor Author

I released postcss-load-config 2.1.1. Can you update it in PR?

Done!

@w0rm
Copy link
Member

w0rm commented Sep 18, 2020

Looks like the tests are failing because postcss has been moved into peerDependencies

@m4thieulavoie
Copy link
Contributor Author

Looks like the tests are failing because postcss has been moved into peerDependencies

Added in in devDependencies so the tests pass

@w0rm
Copy link
Member

w0rm commented Sep 18, 2020

Tests are failing because node 6 is not supported. We need to update travis.yml to test in:

node_js:
  - node
  - "12"
  - "10"

Also the engines setting in package.json needs to reflect the one from postcss: https://github.com/postcss/postcss/blob/master/package.json#L6

@m4thieulavoie
Copy link
Contributor Author

Tests are failing because node 6 is not supported. We need to update travis.yml to test in:

node_js:
  - node
  - "12"
  - "10"

Also the engines setting in package.json needs to reflect the one from postcss: https://github.com/postcss/postcss/blob/master/package.json#L6

Thanks, the build is finally ✅

@w0rm w0rm merged commit f3751c8 into postcss:master Sep 23, 2020
@w0rm
Copy link
Member

w0rm commented Sep 23, 2020

@m4thieulavoie thanks for your PR, I will cut a release shortly

@m4thieulavoie m4thieulavoie deleted the chore/postcss-major-bump branch September 23, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants