check transition-property value list before warn #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai
reviewed
Jan 6, 2021
ai
reviewed
Jan 6, 2021
|
Tests are falling now |
|
The requested changes are done, and I merged the newer commits (new typings were "conflicting" without issue). I also noticed that the autofix linter isn't set up to work on .ts files (which there is now since the new typings merge) "lint-staged": {
"*.js": "eslint --fix"
}, |
|
Thanks. I added I will release these changes next day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR answers the issue #1384 (and following discussion). It includes related tests and code comments.