Fix Cannot read property 'proxyOf' of undefined exception from PostCSS #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just put above the new lines |
|
I can't write test for this particular case, comment added. |
|
Thanks. Released in 10.0.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Yesterday I tried to migrate https://aviasales.com to PostCSS 8 and Autoprefixer 10 and I found a problem, but I couldn't locate it. @ai show me the place, and I fix it.
postcss/postcss#1473
I thinks, code of this PR is kind of dirty, maybe we should change
index()method signature and return-1, if someone pass something unexpected (exactly asArray#indexOfworks)?Actually, I still can not reproduce this error in test-env (it is the reason, why I did not write any new tests), because I do not really understand how this case can be possible. I write this code like a monkey, sorry 馃ぃ