Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning from grid-[column/row]-gap + grid-area combo #1371

Closed
75th opened this issue Nov 3, 2020 · 3 comments
Closed

Remove warning from grid-[column/row]-gap + grid-area combo #1371

75th opened this issue Nov 3, 2020 · 3 comments

Comments

@75th
Copy link

75th commented Nov 3, 2020

Similar to #1157, but also completely different. grid-column-gap affects the child grid, not the parent grid; it and grid-area have nothing to do with each other. But presumably because autoprefixer is looking for grid-column-* properties, it warns about it anyway:

You already have a grid-area declaration present in the rule. You should use either grid-area or grid-column-gap, not both

I think this should be removed.

@ai
Copy link
Member

ai commented Nov 3, 2020

/cc @Dan503

@Dan503
Copy link
Contributor

Dan503 commented Nov 3, 2020

Ok yeah this is a valid bug.

It shouldn't be warning if using grid-column-gap (or grid-row-gap) in combination with grid-area.

The warning is more intended for uses of grid-area in combination with grid-column, grid-column-start, and grid-column-end.

We should be more specific when checking for a match when displaying the warning or explicitly exclude grid-column-gap and grid-row-gap from the warning message check.

@ai
Copy link
Member

ai commented Nov 4, 2020

Fixed 9c9107d

I will release it when we will find a solution for #1369

@ai ai closed this as completed Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants