Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoprefixer Grid does not prefix align/justify-self if display is set to flex #1335

Closed
Dan503 opened this issue Jul 11, 2020 · 1 comment
Closed

Comments

@Dan503
Copy link
Contributor

Dan503 commented Jul 11, 2020

I did some investigating on this comment by @nagman #856 (comment)

This works as expected:

/* Input CSS */
.test {
  align-self: center;
  justify-self: end;
}

/* Output CSS */
.test {
  -ms-grid-row-align: center;
      align-self: center;
  -ms-grid-column-align: end;
      justify-self: end;
}

However this does not:

/* Input CSS */
.test {
  display: flex;
  align-self: center;
  justify-self: end;
}

/* Output CSS */
.test {
  display: flex;
  align-self: center;
  justify-self: end;
}

/* Expected output CSS */
.test {
  display: flex;
  -ms-grid-row-align: center;
      align-self: center;
  -ms-grid-column-align: end;
      justify-self: end;
}

align-self and justify-self are still valid grid alignment options if the element they are on is a flex container. A flex container can be a grid child.

align-self and justify-self should just always add the grid prefixes if grid is enabled.

@Dan503 Dan503 changed the title Autoprefixer Grid does not prefix align-self and justify-self if display is set to grid Autoprefixer Grid does not prefix align/justify-self if display is set to flex Jul 11, 2020
Dan503 pushed a commit to Dan503/autoprefixer that referenced this issue Jul 11, 2020
Dan503 pushed a commit to Dan503/autoprefixer that referenced this issue Jul 11, 2020
@ai ai closed this as completed Jul 11, 2020
@ai
Copy link
Member

ai commented Jul 11, 2020

Thanks. Released in 9.8.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants