Feature/vendor specific transition #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai
reviewed
Oct 28, 2019
ai
reviewed
Oct 28, 2019
ai
reviewed
Oct 28, 2019
ai
reviewed
Oct 29, 2019
ai
reviewed
Oct 29, 2019
ai
reviewed
Oct 29, 2019
ai
reviewed
Oct 29, 2019
| @@ -15,7 +17,8 @@ class Transition { | |||
| add (decl, result) { | |||
| let prefix, prop | |||
| let add = this.prefixes.add[decl.prop] | |||
| let declPrefixes = (add && add.prefixes) || [] | |||
| let vendorPrefixes = this.ruleVendorPrefixes(decl) | |||
| let declPrefixes = vendorPrefixes || (add && add.prefixes) || [] | |||
There was a problem hiding this comment.
I described it here.
lib/transition.js
Outdated
| @@ -33,6 +36,8 @@ class Transition { | |||
| if (!prefixer || !prefixer.prefixes) continue | |||
|
|
|||
| for (prefix of prefixer.prefixes) { | |||
| if (vendorPrefixes && !vendorPrefixes.includes(prefix)) continue | |||
There was a problem hiding this comment.
We can always have array in vendorPrefixes (by returning [] instead of false) and about this extra check.
There was a problem hiding this comment.
I like the idea of returning false cause here we need to check whether rule is vendor specific. If it's not - we don't have to check the prefix. By the way I just found out the check itself
!vendorPrefixes.includes(prefix)works incorrect. Prefix might be -webkit- 2009 for example. I'll fix it.
|
Released in 9.7.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should close #1217 . The issue is about
transitionproperty was prefixed with all of the prefixes even though not all of them are required (like-moz-prefixes in-webkit-rule).