Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid] Implement hack for place-self property #1144

Merged
merged 4 commits into from Oct 20, 2018

Conversation

bogdan0083
Copy link
Contributor

@bogdan0083 bogdan0083 commented Oct 18, 2018

Fixes #1143

The tests for this PR are failing because I need to find a way to make place-self hack to not add prefixes if css grid is disabled (described the problem here)

But the prefixes are being added correctly and can be tested 馃榾

/cc @Dan503

@ai
Copy link
Member

ai commented Oct 19, 2018

@bogdan0083 Thanks. It was really fast. Good work.

But seems like you forget to check processor.gridStatus before accepting this rule (so grid: false or /* autoprefixer grid: off */ will not switch it off).

@Dan503 can I ask you yo make quick look?

@ai
Copy link
Member

ai commented Oct 19, 2018

@Dan503
Copy link
Contributor

Dan503 commented Oct 19, 2018

I'm doing a bit of testing now. I'm also double checking that it works in IE the way I expect it to.

@Dan503
Copy link
Contributor

Dan503 commented Oct 19, 2018

Bogdans Code seems to work exactly as expected. Thanks @bogdan0083! 馃榿

To prove it does what I think it does in IE, here is a code pen:
https://codepen.io/daniel-tonon/pen/gBzXMK

You can view the demo in IE here to prove that the prefixes work:
https://s.codepen.io/daniel-tonon/debug/gBzXMK/VGrWNwpdDYZM

@bogdan0083
Copy link
Contributor Author

@ai I added the condition and the tests are passing now 馃憤

@ai ai merged commit 6b8a25d into postcss:master Oct 20, 2018
@ai
Copy link
Member

ai commented Oct 23, 2018

Released in 9.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[css-grid] place-self can be translated
3 participants