New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-grid] place-self
can be translated
#1143
Comments
Also be aware of the 2 value syntax Input CSS.grid > * {
place-self: start end;
} Current Output CSS.grid > * {
place-self: start end;
} Expected output CSS.grid > * {
-ms-grid-row-align: start;
-ms-grid-column-align: end;
place-self: start end;
} |
Also be aware that if you write this CSS: .grid {
display: grid;
place-items: start end;
} It will output this warning:
This warning is misleading to users as using |
place-self
can be translatedplace-self
can be translated
@bogdan0083 do you want to implement it? |
I tried seeing if I could fix it myself since I need this fixed for the article... I couldn't figure it out though :( @bogdan0083 I need your help getting this one fixed so that I can mention this translation in my new article. |
Sure! I will try to fix this issue 🙂 |
@ai How can I not prefix the property if grid feature is disabled? I added // CSS Grid Layout
let grid = require('caniuse-lite/data/features/css-grid')
f(grid, browsers => {
prefix(['display-grid', 'inline-grid'], {
props: ['display'],
feature: 'css-grid',
browsers
})
prefix([
'grid-template-columns', 'grid-template-rows',
'grid-row-start', 'grid-column-start',
'grid-row-end', 'grid-column-end',
'grid-row', 'grid-column', 'grid-area',
'grid-template', 'grid-template-areas', 'place-self' // here
], {
feature: 'css-grid',
browsers
})
}) The hack works, but the test case with grid disabled (grid.disabled.css) fails, because it still adds Upd 1: I also didn't find Upd 2: Do I need to send PR to |
Released in 9.3 |
I'm kicking myself for not realizing this while we were working on the align/justify-content/items warnings >_<
Input CSS
Current Output CSS
Expected output CSS
The text was updated successfully, but these errors were encountered: