From 8c3797ea66fc694792e7f03003d1717b42d099bb Mon Sep 17 00:00:00 2001 From: Joe Cheng Date: Thu, 20 Oct 2022 14:23:17 -0700 Subject: [PATCH 1/2] Remove --reload flag; this option is no longer in uvicorn --- shiny/_main.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/shiny/_main.py b/shiny/_main.py index 2e84ea9e1..80df6ed99 100644 --- a/shiny/_main.py +++ b/shiny/_main.py @@ -63,9 +63,6 @@ def main() -> None: help="Bind autoreload socket to this port. If 0, a random port will be used. Ignored if --reload is not used.", show_default=True, ) -@click.option( - "--debug", is_flag=True, default=False, help="Enable debug mode.", hidden=True -) @click.option("--reload", is_flag=True, default=False, help="Enable auto-reload.") @click.option( "--ws-max-size", @@ -108,7 +105,6 @@ def run( host: str, port: int, autoreload_port: int, - debug: bool, reload: bool, ws_max_size: int, log_level: str, @@ -121,7 +117,6 @@ def run( host=host, port=port, autoreload_port=autoreload_port, - debug=debug, reload=reload, ws_max_size=ws_max_size, log_level=log_level, @@ -136,7 +131,6 @@ def run_app( host: str = "127.0.0.1", port: int = 8000, autoreload_port: int = 0, - debug: bool = False, reload: bool = False, ws_max_size: int = 16777216, log_level: Optional[str] = None, @@ -165,8 +159,6 @@ def run_app( autoreload_port The port that should be used for an additional websocket that is used to support hot-reload. Set to 0 to use a random port. - debug - Enable debug mode. reload Enable auto-reload. ws_max_size @@ -246,7 +238,6 @@ def run_app( app, # pyright: ignore[reportGeneralTypeIssues] host=host, port=port, - debug=debug, reload=reload, reload_dirs=reload_dirs, ws_max_size=ws_max_size, From 7ee8a661242f719db5a77c3226a2de77a3551349 Mon Sep 17 00:00:00 2001 From: Joe Cheng Date: Thu, 20 Oct 2022 14:25:32 -0700 Subject: [PATCH 2/2] Add changelog notes --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ee10365a0..8b568f813 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 * `panel_conditional` now works correctly inside of Shiny modules. (Thanks, @gcaligari!) (#336) +* Fix compatibility with Uvicorn 0.19.0 (#357) + ### Other changes