Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data frame editing example doesn't work correctly #1347

Open
wch opened this issue May 1, 2024 · 1 comment
Open

Data frame editing example doesn't work correctly #1347

wch opened this issue May 1, 2024 · 1 comment
Assignees
Labels
bug Something isn't working data frame Related to @render.data_frame
Milestone

Comments

@wch
Copy link
Collaborator

wch commented May 1, 2024

From https://shiny.posit.co/py/api/express/express.render.data_frame.html (and the core version), the third example app doesn't work correctly. It is meant to save the changes, but it only saves the most recent change to the data, instead of all the cumulative changes.

The examples are at:

@wch
Copy link
Collaborator Author

wch commented May 1, 2024

@schloerke I changed the example in #1348 so that it works, but I feel like there could be a better way to do it. I'll merge and deploy now but we should revisit it when you are available.

@schloerke schloerke added the data frame Related to @render.data_frame label May 8, 2024
@schloerke schloerke added this to the v0.9.1 milestone May 8, 2024
@schloerke schloerke added the bug Something isn't working label May 8, 2024
@schloerke schloerke modified the milestones: v0.10.0, v0.11.0 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data frame Related to @render.data_frame
Projects
None yet
Development

No branches or pull requests

2 participants