New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type of timeout #118

Merged

porsager merged 1 commit into porsager:master from karlhorky:patch-1

Oct 23, 2020

Contributor

karlhorky commented Oct 23, 2020

TypeScript complains that timeout needs to be number | undefined.

Not sure if 0 is semantically the same as null in this case, so happy to fix if not!


          Fix type of timeout

a6f55bf

Owner

porsager commented Oct 23, 2020

Ah nice catch. Thanks.

porsager merged commit c2c0bf1 into porsager:master

karlhorky deleted the patch-1 branch

October 23, 2020 11:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment