-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: handle scaled parent elements #1247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change Log for @popperjs/core (2.9.2 → 2.9.3)Bug Fixes
|
|
@FezVrasta https://github.com/twbs/bootstrap/compare/main-xmr-test-popper (ignore the lint failure) Not sure how to test this since including your branch seems to break building. |
Sorry, nevermind, there are some of our own E2E tests that are failing, we'll need to fix them first. |
Hi. Just checking to see if there are plans to merge this in once tests pass? |
I don't have time to fix the code so that tests pass. Contributions are welcome |
I've written up some logic to only apply the scale in I added a few more test cases for some combinations of reference, popper, and parent elements being scaled. I'm not convinced that this isn't going to break anything else or work for all scales scenarios, but all the tests pass (except one functional test in If you want to give me access, I can create a branch off of this branch and make a PR if you want. |
Feel free to branch this out, it'd be great to get this fixed |
PR here: #1322 with the above-mentioned changes. |
As far as I can tell, our popper's ancestor elements have no scaling applied, but upgrading from |
Please open a new issue |
The |
fixes #376