feat: add roundOffsets option to computeStyles modifier

[piecyk]

As reported in #1169 rounding logic in some cases makes the popper not correctly aligned with reference element. This PR adds possibility to opt out from it via roundOffsets option.

createPopper(reference, popper, {
  modifiers: [
    {
      name: 'computeStyles',
      options: {
        roundOffsets: false,
      },
    },
  ],
});

[rollingversions]

Change Log for @popperjs/core (2.5.4 → 2.6.0)

New Features

• Add roundOffsets option to computeStyles modifier

Edit changelog

[FezVrasta]

Can't we fix the rounding algorithm instead? We have quite a lot of tests that cover it already.

[piecyk]

Can't we fix the rounding algorithm instead? We have quite a lot of tests that cover it already.

I think it will be hard to make a fix that will work cross browser.

Also while testing locally latest chrome/firefox/edge/safari with opting out, didn't break the rendering as mainly that's the reason for rounding.

[piecyk]

Why we had this round functions on start/end variation? Imho they are not needed as latter we still round the offsets 🤔

[FezVrasta]

@atomiks? 👀

[piecyk]

Maybe I should add more tests 🤔 Also this change didn't break any existing one.

[FezVrasta]

The PR looks good, I'm just a bit worried about this bit. Let's give @atomiks a couple more days to review it and if he doesn't find time I'll merge it as dog food it to the whole user base :-)

[piecyk]

Looks like no other comments. IMHO let's merge this 🤞 💪

[piecyk]

Don't really see a way to improve rounding algorithm to be more accurate 🤷‍♂️ Maybe till then we can have this opt out option.

[piecyk]

Changed this to keep the rounding logic in computeStyles modifier, added roundOffsets option as boolean to modifier options as in PR description. Was wondering also if not allow to pass custom function, so then user of modifier can tweak the rounding.

[FezVrasta]

Merged, thanks for the help! Could you also send a PR on the computeStyles docs? here

[piecyk]

Could you also send a PR on the computeStyles docs?

Yes, will do.

[piecyk]

@FezVrasta when are you planing releasing this? I think patch release will be good in this case. Also thanks for this 👏

[FezVrasta]

Releasing