Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add auto error #1143

Merged
merged 1 commit into from Jun 27, 2020
Merged

fix: add auto error #1143

merged 1 commit into from Jun 27, 2020

Conversation

atomiks
Copy link
Collaborator

@atomiks atomiks commented Jun 27, 2020

In the case that the placement is "auto", but they only specify `"bottom-start" as an allowed placement, it doesn't make sense — this adds a helpful error message that lets them know.

Closes #1133

@rollingversions
Copy link

rollingversions bot commented Jun 27, 2020

Change Log for @popperjs/core (2.4.2 → 2.4.3)

Bug Fixes

Edit changelog

@FezVrasta FezVrasta merged commit 777ebbb into floating-ui:master Jun 27, 2020
@FezVrasta FezVrasta deleted the fix/auto-error branch June 27, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] allowedAutoPlacements throws error if -start modifier present on placement
2 participants