Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile task "publish" not necessary anymore #6367

Closed
matthiasbeyer opened this issue Jan 22, 2023 · 1 comment
Closed

Makefile task "publish" not necessary anymore #6367

matthiasbeyer opened this issue Jan 22, 2023 · 1 comment

Comments

@matthiasbeyer
Copy link

polars/polars/Makefile

Lines 90 to 113 in f2e54b1

publish:
cargo publish --allow-dirty -p polars-arrow
sleep 20
cargo publish --allow-dirty -p polars-utils
sleep 20
cargo publish --allow-dirty -p polars-core
sleep 20
cargo publish --allow-dirty -p polars-ops
sleep 20
cargo publish --allow-dirty -p polars-time
sleep 20
cargo publish --allow-dirty -p polars-io
sleep 20
cargo publish --allow-dirty -p polars-plan
sleep 20
cargo publish --allow-dirty -p polars-pipe
sleep 20
cargo publish --allow-dirty -p polars-lazy
sleep 20
cargo publish --allow-dirty -p polars-algo
sleep 20
cargo publish --allow-dirty -p polars-sql
sleep 20
cargo publish --allow-dirty -p polars

I found this while browsing the codebase. I think this is not necessary anymore, because cargo can now publish workspaces (relevant issue: rust-lang/cargo#1169).

May be worth a try.

@ritchie46
Copy link
Member

Thanks! That looks interesting. I shall keep this in mind on next releases. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants