From 6f34ff9b4c4fcb773f4727f7c83475fadd1f52b8 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Wed, 16 Feb 2022 13:00:08 +0100 Subject: [PATCH] test: fix Go version matrix The matrix didn't really have an effect, all tests ran with the same (default?) Go version. For example, the "1.17.x, ubuntu-latest" test https://github.com/kubernetes/klog/runs/5215345316?check_suite_focus=true for https://github.com/kubernetes/klog/pull/297 complained about functions that are available in 1.17: Error: logcheck/pkg/filter_test.go:28:12: undefined: os.WriteFile Error: logcheck/pkg/filter_test.go:132:14: undefined: os.WriteFile --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 5ff4d899..38793a37 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -4,7 +4,7 @@ jobs: test: strategy: matrix: - go-versions: [1.14.x, 1.15.x, 1.16.x, 1.17.x] + go-version: [1.14, 1.15, 1.16, 1.17] platform: [ubuntu-latest, macos-latest, windows-latest] runs-on: ${{ matrix.platform }} steps: