Support url parameter

[bakerbrooklyn]

Steps to reproduce the issue

1. I try to render this SVG file: "https://upload.wikimedia.org/wikipedia/commons/f/fc/Flag_of_Mexico.svg"
2. Keep getting Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid parameter not satisfying: [str hasPrefix:@"#"]'

Please include all relevant code, including all PocketSVG method calls made.

Has my issue been reported?

My issue has been reported in the following closed issues:

Specifications

• PocketSVG Version: HEAD
• Xcode Version: 9.x
• iOS/macOS Version: iOS 11.x

[arielelkin]

The assertion fails with this tag: <ellipse fill="url(#rg1)"

Unfortunately, we don't support the url parameter yet.

[ngthanhtan91]

is there any update for this feature? I got this issue two

[arielelkin]

We hope to work on this feature request, but unfortunately we cannot at this stage give you a timeframe for when it'll be done. Pull requests are always welcome, of course :-)

In the meantime, a workaround is to rewrite the url parameters in your SVG file.

[kritikaperiwal12]

I also get the same error, is there any solution for this?
@arielelkin

[arielelkin]

As we said above, we don't support the url parameter yet unfortunately. We hope to work on this feature request, but unfortunately we cannot at this stage give you a timeframe for when it'll be done. Pull requests are always welcome, of course :-)

Would it help if we print an error message instead of throwing an exception ?

[fjolnir]

Only printing an error log would just make things fail unnoticed.

URL loading is not an appropriate feature for a simple (de)serializer like pocketSVG. although url(#rg1) looks like some sort of file-local reference, so that limited support for that might be an acceptable PR. But not something I would spend time on.