Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifications for lockfile versions >= 5.3? #4

Open
adamcohen2 opened this issue Feb 6, 2023 · 10 comments
Open

Specifications for lockfile versions >= 5.3? #4

adamcohen2 opened this issue Feb 6, 2023 · 10 comments

Comments

@adamcohen2
Copy link

adamcohen2 commented Feb 6, 2023

I've noticed that the specifications only exist up to lockfile version 5.2. Are there any details on the specifications for lockfile versions 5.3, 5.4 and 6? Thanks!

@samwhite-gl
Copy link

Tagging @zkochan since it is not clear if this issue tracker is monitored.

@adamcohen2 adamcohen2 changed the title Specifications for lockfile version 5.3 and 5.4? Specifications for lockfile versions >= 5.3? Feb 6, 2023
@zkochan
Copy link
Member

zkochan commented Feb 7, 2023

no, they are not documented. But v6 is almost the same as v5

@kzantow
Copy link

kzantow commented Apr 26, 2023

I've had a hard time finding out what the correct schemas are to parse. At what point did dependencies change from a simple string to a struct?

v5.4 (which is undocumented):

lockfileVersion: 5.4

dependencies:
  nanoid: 3.3.4

v6 (which is also undocumented):

lockfileVersion: '6.0'

dependencies:
  '@testing-library/jest-dom':
    specifier: ^5.16.5
    version: 5.16.5

@zkochan
Copy link
Member

zkochan commented Apr 27, 2023

in v6

@DmitriyLewen
Copy link

Hello @zkochan
Can you clarify:
v5 has next package format: <pkg_name>/<pkg_version> (/foo/1.0.0). For non-default registry - registry.node-modules.io/foo/1.0.0

but, if i understand correctly, v6 uses <pkg_name>@<pkg_version> format (pnpm/pnpm#5810)
What would the v6 format look like for a private registry?

Best regards, Dmitriy!

@zkochan
Copy link
Member

zkochan commented May 23, 2023

It will be registry.node-modules.io/foo@1.0.0

@DmitriyLewen
Copy link

Thanks for the quick response!

@RahulGautamSingh
Copy link

RahulGautamSingh commented May 25, 2023

Will the docs be updated to mention the change in the schema of dependencies? I would like to do it in a PR(have the time) but I am not sure if I will be able to mention all the additional details, which you could.

@DmitriyLewen
Copy link

Hi @RahulGautamSingh!

If you do, may I ask you to add the information that lockfileVersion is a string in v6.

Thank you in advance

@zkochan
Copy link
Member

zkochan commented May 27, 2023

added a v6 doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants