Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node@22 #6003

Open
1 task
milanholemans opened this issue Apr 29, 2024 · 2 comments · May be fixed by #6016
Open
1 task

Support Node@22 #6003

milanholemans opened this issue Apr 29, 2024 · 2 comments · May be fixed by #6016

Comments

@milanholemans
Copy link
Contributor

milanholemans commented Apr 29, 2024

Kudos to @waldekmastykarz for noticing.


A few days ago, Node.js v22 became current, and Node.js v20 moved to LTS. Let's move CLI to the new version.

Tasks (both for PR and release pipelines):

  • Add Node@22 as a single test pipeline without coverage for Ubuntu/Linux.
@milanholemans milanholemans added enhancement needs peer review Needs second pair of eyes to review the spec or PR labels Apr 29, 2024
@waldekmastykarz
Copy link
Member

Typically, we build and package on LTS because that's the version we recommend folks use, so I suggest we keep the current config and simply add v22 as another version to test on (but not run the coverage).

@milanholemans
Copy link
Contributor Author

Ow yeah, you are right, was a bit too fast there 😊

@waldekmastykarz waldekmastykarz added help wanted and removed needs peer review Needs second pair of eyes to review the spec or PR labels Apr 30, 2024
@milanholemans milanholemans self-assigned this May 2, 2024
@milanholemans milanholemans linked a pull request May 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants