New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement add cliEntraAppId and cliEntraAppTenant configurations settings for cli config
commands
#5995
Comments
We should use the new config options wherever we refer to |
ok, noted. You can assign me to this task since I've already made some research on this topic. |
Currently, all our config settings are not tenant-bound. If we implement this, it will clash when switching connections (when switching to another tenant). I'm wondering if this is problematic here. |
Hi, @milanholemans Isn't it similar to using the 'CLI MICROSOFT365 TENANT' option? Perhaps it's a helpful clue. There's a distinction when a user sets 'CLI MICROSOFT365 TENANT' parameter themselves and encounters an issue, versus when issues arise from setting it the 'supported way' in background, using |
Yes, but |
Hi @milanholemans, The new configuration setting will be only used for If you're referring only to the But to summarize, we have a few options to choose from:
What do you think @milanholemans ? |
I have no idea whether or not you can update an environment variable to be honest. I'm just a bit concerned that we are creating now 2 paths to achieve the same thing, which I don't really like. In my humble opinion, we should either get rid of the env variables or just not set the app ID and tenant ID of the new app registration at all. Currently, I'm leaning towards the latter. |
@milanholemans I suppose removing environment variables is no longer an option since they are currently being used by users. Ok, I believe the solution for @waldekmastykarz Would it be ok? |
If needed, we can remove them in the next major release. Have you tried setting an environment variable like we do here? cli-microsoft365/src/appInsights.ts Lines 3 to 5 in 5f64790
Or is this not something persistent? |
@milanholemans Exactly, I have tried the same approach: Unfortunately, the result is as follows. In debugging, I can see that this value is assigned correctly, but perhaps it is valid only during the execution. |
As discussed in this thread #5985 (comment)
The aim of the task is to add the cliEntraAppId and cliEntraAppTenant options to the list of available settings for:
cli config get
,cli config list
,cli config reset
,cli config set
.Later the new options will be utilized in
cli app add
command.The importance of the app ID setting would be as follows:
The importance of the tenant setting would be as follows:
The text was updated successfully, but these errors were encountered: