Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Remark #206

Closed
mrwokkel opened this issue Mar 21, 2021 · 3 comments
Closed

Update Remark #206

mrwokkel opened this issue Mar 21, 2021 · 3 comments

Comments

@mrwokkel
Copy link

Latest version seems to use new parser (micromark). Plugins depend on it. See remarkjs/remark#536

@pngwn
Copy link
Owner

pngwn commented Mar 21, 2021

mdsvex is not currently compatible with the micromark changes.

Updating remark is a huge can of worms, there are lots of remark plugins that do not currently work with the new micromark parser as the API for syntax extensions has changed substantially.

I am currently reconsidering whether to continue making use of the unified ecosystem for a variety of reasons, I have some changes in the works that will address a number of issues in the backlog (probably about half of them) and the micromark change is causing me a significant headache.

I'll update in due course.

@pzuraq
Copy link

pzuraq commented Apr 4, 2022

Any word on this? Seems like a lot of the remark plugins are updating now, so they're no longer compatible with mdsvex. I realize this is probably a large project, could definitely lend a hand to help out.

@archiewood
Copy link

archiewood commented Dec 16, 2022

You may be aware of this, but node now spits out a vulnerability about remark <=8.0.3, reported on May 10th 2022.

# npm audit report

trim  <0.0.3
Severity: high
Regular Expression Denial of Service in trim - https://github.com/advisories/GHSA-w5p7-h5w8-2hfq
fix available via `npm audit fix --force`
node_modules/trim
  remark-parse  <=8.0.3
  Depends on vulnerable versions of trim
  node_modules/remark-parse

We tried upgrading remark, but this broke MDSveX for us, so now we're back on 8.0.2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants