Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polar Plot #7

Open
polvalente opened this issue Aug 29, 2023 · 4 comments
Open

Polar Plot #7

polvalente opened this issue Aug 29, 2023 · 4 comments
Labels
enhancement New feature or request v0.3 Issues planned for v0.3

Comments

@polvalente
Copy link

Are polar plots something that would be welcome here?
I have this PR open on VegaLite, but with the presence of this higher level library, it might be welcome here instead.

The only thing I'm not sure about is that the higher level API might not support the current structuring of the code.

@pnezis
Copy link
Owner

pnezis commented Aug 29, 2023

Hi @polvalente, polar plots would be definitely welcome here. Probably we would add it to a Tucan.Polar module since they are more specialised.

The code uses VegaLite under the hook, and from a quick look at the current PR the port seems straight forward. You can take a stab on this if you want.

A function for appending layers was already in the plans in order to support some other features of the backlog.

@polvalente
Copy link
Author

I believe append_layers would still be accepted in VegaLite, even though they're deprecating VegaLite.Data (@josevalim, can you confirm?)

Having that available, how would we go about bringing that code in? Would it be a line-by-line port, or would it have to be translated into the Tucan API?

I'm also not sure about how part of the API would work with the current code (e.g. coloring only the line layers instead of the grid)

@josevalim
Copy link

I believe append_layers would still be accepted in VegaLite, even though they're deprecating VegaLite.Data (@josevalim, can you confirm?)

Correct.

@pnezis pnezis added enhancement New feature or request v0.2 labels Aug 31, 2023
@pnezis
Copy link
Owner

pnezis commented Aug 31, 2023

@polvalente I added append_layers and prepend_layers in order to support layering of horizontal - vertical lines (#10). Will try to add polar plots support into the weekend.

@pnezis pnezis added v0.3 Issues planned for v0.3 and removed v0.2 labels Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v0.3 Issues planned for v0.3
Projects
None yet
Development

No branches or pull requests

3 participants