From 14161cf3355196eff1549ab11bb56fc3d79fc593 Mon Sep 17 00:00:00 2001 From: Cody Bennett <23324155+CodyJasonBennett@users.noreply.github.com> Date: Mon, 3 Oct 2022 01:41:15 -0500 Subject: [PATCH 1/2] fix: call onUpdate for attached children prop update --- packages/fiber/src/core/utils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/fiber/src/core/utils.ts b/packages/fiber/src/core/utils.ts index c9c4810d44..af849172f8 100644 --- a/packages/fiber/src/core/utils.ts +++ b/packages/fiber/src/core/utils.ts @@ -352,7 +352,7 @@ export function applyProps(instance: Instance, data: InstanceProps | DiffSet) { } // Call the update lifecycle when it is being updated, but only when it is part of the scene - if (changes.length && instance.parent) updateInstance(instance) + if (changes.length && instance.__r3f.parent) updateInstance(instance) return instance } From bf254b00e806ade5a672146b1d68b54e8df005f4 Mon Sep 17 00:00:00 2001 From: Cody Bennett <23324155+CodyJasonBennett@users.noreply.github.com> Date: Mon, 3 Oct 2022 01:43:17 -0500 Subject: [PATCH 2/2] fix: safely check __r3f --- packages/fiber/src/core/utils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/fiber/src/core/utils.ts b/packages/fiber/src/core/utils.ts index af849172f8..fd9606e0da 100644 --- a/packages/fiber/src/core/utils.ts +++ b/packages/fiber/src/core/utils.ts @@ -352,7 +352,7 @@ export function applyProps(instance: Instance, data: InstanceProps | DiffSet) { } // Call the update lifecycle when it is being updated, but only when it is part of the scene - if (changes.length && instance.__r3f.parent) updateInstance(instance) + if (changes.length && instance.__r3f?.parent) updateInstance(instance) return instance }