New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: invalidate pierced props #2549
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1205150:
|
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@react-three/fiber](https://togithub.com/pmndrs/react-three-fiber) | [`8.8.9` -> `8.8.10`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.8.9/8.8.10) | [![age](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.8.10/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.8.10/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.8.10/compatibility-slim/8.8.9)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.8.10/confidence-slim/8.8.9)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pmndrs/react-three-fiber</summary> ### [`v8.8.10`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.8.10) [Compare Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.8.9...v8.8.10) #### What's Changed - fix: invalidate pierced props by [@​CodyJasonBennett](https://togithub.com/CodyJasonBennett) in [pmndrs/react-three-fiber#2549 **Full Changelog**: pmndrs/react-three-fiber@v8.8.9...v8.8.10 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMzIuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIzMi4wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@CodyJasonBennett I'm not sure how, but I think this broke |
@vpontis, do you have a minimum affected version of R3F/Drei or were you able to track it down to this PR? I'd create an issue with a reproduction if possible. |
Yea, the last version we have that works is |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@react-three/fiber](https://togithub.com/pmndrs/react-three-fiber) | [`8.8.9` -> `8.8.10`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.8.9/8.8.10) | [![age](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.8.10/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.8.10/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.8.10/compatibility-slim/8.8.9)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.8.10/confidence-slim/8.8.9)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pmndrs/react-three-fiber</summary> ### [`v8.8.10`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.8.10) [Compare Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.8.9...v8.8.10) #### What's Changed - fix: invalidate pierced props by [@​CodyJasonBennett](https://togithub.com/CodyJasonBennett) in [pmndrs/react-three-fiber#2549 **Full Changelog**: pmndrs/react-three-fiber@v8.8.9...v8.8.10 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMzIuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIzMi4wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Invalidates pierced props whenever their root is changed (e.g.
map-needsUpdate
in<material map={map} map-needsUpdate />
.