Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: v9 goals #2338

Open
11 of 18 tasks
krispya opened this issue Jun 22, 2022 · 11 comments · May be fixed by #2331
Open
11 of 18 tasks

RFC: v9 goals #2338

krispya opened this issue Jun 22, 2022 · 11 comments · May be fixed by #2331
Labels
request for comments come & have your say

Comments

@krispya
Copy link
Member

krispya commented Jun 22, 2022

Let's discuss some v9 goals here. These are all tentative right now.

Completed

TODO

Pending

  • New scheduler
  • Refactor internal state
@CodyJasonBennett CodyJasonBennett added the request for comments come & have your say label Jun 23, 2022
@krispya
Copy link
Member Author

krispya commented Jun 24, 2022

I'd also like to discuss making renderer.physicallyCorrectLights = true by default. See: #2127

@CodyJasonBennett CodyJasonBennett pinned this issue Sep 3, 2022
@CodyJasonBennett
Copy link
Member

I don't think we can change defaults for lighting OOTB, problems are detailed in the linked issue. That might be a consideration for #2299 but the issue of decay not respecting physicallyCorrectLights remains. I think this is something to be considered in threejs itself.

@CodyJasonBennett CodyJasonBennett linked a pull request Sep 3, 2022 that will close this issue
@CodyJasonBennett CodyJasonBennett linked a pull request Sep 3, 2022 that will close this issue
@krispya
Copy link
Member Author

krispya commented Sep 23, 2022

I don't think we can change defaults for lighting OOTB, problems are detailed in the linked issue. That might be a consideration for #2299 but the issue of decay not respecting physicallyCorrectLights remains. I think this is something to be considered in threejs itself.

Agreed.

After a conversation with Paul, I'm making sure a pass on the frameloop modes is also on the to-do list. In particular demand needs to be updated so that it skips the render loop but still tracks delta so starting and stopping render doesn't destroy delta based animations.

@saitonakamura
Copy link
Sponsor Contributor

What are your thoughts on updating to zustand v4?

@krispya
Copy link
Member Author

krispya commented Oct 4, 2022

I'm in favor, the typing is hugely improved and so is compatibility with context. But it isn't a trivial update. Is it something you would be interested in spearheading? I can contribute.

@saitonakamura
Copy link
Sponsor Contributor

saitonakamura commented Oct 5, 2022

Yeah, I think so. When upgrading to r3f v8 I erroneously update zustand to v4. I had to revert back of course but not until I had some fair share of migration experience (we use it too)

@krispya
Copy link
Member Author

krispya commented Oct 5, 2022

That would be great. If you start a branch, I can do review and assist.

@CodyJasonBennett
Copy link
Member

CodyJasonBennett commented Oct 10, 2022

Just did this with react-ogl in pmndrs/react-ogl#75, giving it a try here in #2558.

@krispya
Copy link
Member Author

krispya commented Nov 28, 2022

Thanks so much for all your hard work Cody. I wanted to add here some type exports for the different r3f props which were previously exported as Vector3, Color, etc.

@aspheris
Copy link

Hello! Whats the status of V9? I'm looking to use the lifecycle stages in useUpdate but it looks like its not officially ready yet.

@krispya
Copy link
Member Author

krispya commented Jun 19, 2023

Hello! Whats the status of V9? I'm looking to use the lifecycle stages in useUpdate but it looks like its not officially ready yet.

Hey! So we have been working on projects in parallel to this one and trying out some of the v9 updates internally as we go along. For example, I am exploring alternatives to useUpdate that are more robust for video game style apps right now. It may be a little bit longer before there is a stable version available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request for comments come & have your say
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants