Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: blurPass and getBlurPass both marked as deprecated in DepthOfFieldEffect #415

Closed
alexpineda opened this issue Oct 18, 2022 · 2 comments
Closed

Minor: blurPass and getBlurPass both marked as deprecated in DepthOfFieldEffect #415

alexpineda opened this issue Oct 18, 2022 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@alexpineda
Copy link

property value here marked as deprecated:

https://github.com/pmndrs/postprocessing/blob/main/src/effects/DepthOfFieldEffect.js#L172

getBlurPass() here marked as deprecated:
https://github.com/pmndrs/postprocessing/blob/main/src/effects/DepthOfFieldEffect.js#L313

No where else to go!
@vanruesc
Copy link
Member

Oh, that's an oversight, blurPass is supposed to be readonly. Feel free to use it - will be fixed in the next release.

@vanruesc vanruesc added the documentation Improvements or additions to documentation label Oct 18, 2022
@vanruesc
Copy link
Member

Fixed in postprocessing@6.29.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexpineda @vanruesc