Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grid #1186

Merged
merged 6 commits into from Dec 17, 2022
Merged

feat: grid #1186

merged 6 commits into from Dec 17, 2022

Conversation

drcmda
Copy link
Member

@drcmda drcmda commented Dec 17, 2022

Port of https://github.com/threlte/threlte/blob/main/packages/extras/src/lib/components/Grid/Grid.svelte by @grischaerbe

  • Documentation updated
  • Storybook entry added
  • Ready to be merged

btw @grischaerbe i noticed the original is missing tonemapping and encoding fragments, the colors weren't managed. i'm also not 100% sure but i removed axes because i think it can just be rotated via mesh.rotation. at work we have a grid component that has distance attenuation, similar to how grids work in CAD. i will ask colleagues if they can add, that would be a super useful addition imo.

@vercel
Copy link

vercel bot commented Dec 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
drei ✅ Ready (Inspect) Visit Preview Dec 17, 2022 at 1:42PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 17, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d11bc64:

Sandbox Source
fast-wood-mqoj53 Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@github-actions
Copy link

🎉 This PR is included in version 9.47.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@grischaerbe
Copy link

Thanks @drcmda! Credit where credit's due, this component is by @jerzakm 🙂 Feel free to port your improvements back to threlte.

@drcmda
Copy link
Member Author

drcmda commented Dec 17, 2022

Thanks @drcmda! Credit where credit's due, this component is by @jerzakm 🙂 Feel free to port your improvements back to threlte.

i think the original is https://github.com/Fyrestar/THREE.InfiniteGridHelper, it just popped up on three discourse, but either way now everyone's mentioned

@jerzakm
Copy link

jerzakm commented Dec 17, 2022

Thanks @drcmda! Credit where credit's due, this component is by @jerzakm 🙂 Feel free to port your improvements back to threlte.

i think the original is Fyrestar/THREE.InfiniteGridHelper, it just popped up on three discourse, but either way now everyone's mentioned

Yeah, that's correct. Threlte grid is an implementation of a quick hacked demo I did a few weeks ago. Credits got lost in comment cleanup.
https://github.com/jerzakm/threlte-experiments/blob/main/src/routes/04_helper-grid/HelperGrid.svelte

Thanks for tips and improvements on it too, we're going to implement asap! 🚀😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants