Stop all AnimationActions on unmount/mixer change #1176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
resolves #1175
What
Added useEffect to stop actions when the mixer changes.
Checklist
[ x ] Documentation updated
[ x ] Storybook entry added
[ x ] Ready to be merged
Comments
Not sure, if this is ready to be merged tbh. but it fixes my bug at least... But it might have second-order consequences that I am not aware of / think of since I am quite new to the whole drei/r3f/three.js ecosystem.