Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove TransformControls events from cleanup #1171

Merged
merged 1 commit into from Dec 7, 2022

Conversation

AlaricBaraou
Copy link
Contributor

Why

Events function were returned in useLayoutEffect which caused them to be called on unmount etc

What

added void in front

Checklist

  • Ready to be merged

@vercel
Copy link

vercel bot commented Dec 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
drei ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 5:23AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 7, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 54b9008:

Sandbox Source
wandering-dawn-mbmw20 Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

🎉 This PR is included in version 9.46.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants