feat: add types to keyboard controls #1118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
KeyboardControlsEntry
wasn't exported, so it wasn't easy to define this outside the component.useKeyboardControls()
always returnedany
because TS couldn't resolve the function, which is not fun for TS devs.What
KeyboardControls
story:/?path=/story/controls-keyboardcontrols--keyboard-controls-st
KeyboardControlsEntry
is now exported and is optionally generic.useKeyboardControls()
now returns the correct types for each case, because the function overloading declarations have been added.useKeyboardControls()
now supports generics, so you can pass which keys you are expected to use.For example, consider you have a
Controls
enum, you can now pass that as a generic and get the correct types for all case scenarios:Checklist