Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TransformControls): prefer refcallbacks for handlers #1095

Merged
merged 1 commit into from Oct 13, 2022

Conversation

CodyJasonBennett
Copy link
Member

Prefers ref-callbacks to play nice with batched updates in React since the handler effect is otherwise rerunning with parent state updates.

@vercel
Copy link

vercel bot commented Oct 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
drei ✅ Ready (Inspect) Visit Preview Oct 13, 2022 at 1:04PM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 20c687b:

Sandbox Source
vigorous-mcclintock-rockn0 Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@CodyJasonBennett CodyJasonBennett merged commit d0b21a6 into master Oct 13, 2022
@CodyJasonBennett CodyJasonBennett deleted the fix/transformcontrols-ref-callback branch October 13, 2022 14:47
@github-actions
Copy link

🎉 This PR is included in version 9.34.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant