From 8884ac40ac51b5622d7cb6b0d4a12f6d4790b873 Mon Sep 17 00:00:00 2001 From: Michael Mok Date: Tue, 26 Apr 2022 00:26:31 +0200 Subject: [PATCH 1/3] ci: test on node 18 --- .circleci/config.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index f7a33320..a08c8e40 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -4,14 +4,14 @@ anchors: - &node-version-enum - '12.22' - '14.19' - - '16.13' - - '17.4' + - '16.14' + - '18.0' - &webpack-version-enum - '4' - '5' - &node-version-param node-version: - default: '16.13' + default: '16.14' enum: *node-version-enum type: enum - &webpack-version-param From 2eb6cbc08ecfa1a7b383944e6b3a0ebf8a87dbdb Mon Sep 17 00:00:00 2001 From: Michael Mok Date: Sat, 21 May 2022 21:40:44 +0200 Subject: [PATCH 2/3] chore: use node.js 18.2 --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index a08c8e40..aff0d96f 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -5,7 +5,7 @@ anchors: - '12.22' - '14.19' - '16.14' - - '18.0' + - '18.2' - &webpack-version-enum - '4' - '5' From 9ebd58152060bac7251e0d5860b997428acae534 Mon Sep 17 00:00:00 2001 From: Michael Mok Date: Sat, 21 May 2022 21:40:52 +0200 Subject: [PATCH 3/3] fix: remove debug console.log --- sockets/utils/getSocketUrlParts.js | 1 - 1 file changed, 1 deletion(-) diff --git a/sockets/utils/getSocketUrlParts.js b/sockets/utils/getSocketUrlParts.js index 10d3881d..dc0a4a5f 100644 --- a/sockets/utils/getSocketUrlParts.js +++ b/sockets/utils/getSocketUrlParts.js @@ -117,7 +117,6 @@ function getSocketUrlParts(resourceQuery, metadata) { } if (!urlParts.hostname || !urlParts.pathname) { - console.log(urlParts); throw new Error( [ '[React Refresh] Failed to get an URL for the socket connection.',