Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix #3768 SARIF: report each violation as separate result #3788

Merged
merged 2 commits into from Feb 25, 2022
Merged

[core] Fix #3768 SARIF: report each violation as separate result #3788

merged 2 commits into from Feb 25, 2022

Conversation

adangel
Copy link
Member

@adangel adangel commented Feb 17, 2022

Now one violation is mapped to exactly one result.

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel
[core] Fix SARIF formatter reporting multiple locations
6b2dde8 
... when it should report multiple results instead.
Now one violation is mapped to exactly one result.

Fixes pmd#3768
@adangel
[core] Refactoring renderer tests
3eed116
@adangel adangel added this to the 6.43.0 milestone Feb 17, 2022
@pmd-test
Copy link

1 Message
📖 This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@adangel adangel changed the title [core] Fix #3768 report each violation as separate result [core] Fix #3768 SARIF report each violation as separate result Feb 19, 2022
@adangel adangel changed the title [core] Fix #3768 SARIF report each violation as separate result [core] Fix #3768 SARIF: report each violation as separate result Feb 19, 2022
@adangel adangel merged commit 9a437b0 into pmd:master Feb 25, 2022
@adangel adangel deleted the issue-3768-sarif-multiple-locations branch February 25, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.43.0
Development

Successfully merging this pull request may close these issues.

[core] SARIF formatter reports multiple locations when it should report multiple results
2 participants
@adangel @pmd-test