Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] SARIF formatter reports multiple locations when it should report multiple results #3768

Closed
adangel opened this issue Feb 10, 2022 · 0 comments · Fixed by #3788
Closed

[core] SARIF formatter reports multiple locations when it should report multiple results #3768

adangel opened this issue Feb 10, 2022 · 0 comments · Fixed by #3788
Assignees
@adangel
Labels
a:bug PMD crashes or fails to analyse a file.
Milestone
6.43.0

Comments

@adangel
Copy link
Member

adangel commented Feb 10, 2022

Affects PMD Version: 6.42.0

Description:

See pmd/pmd-github-action#53 for the details.
In short, the SARIF renderer doesn't adhere to the spec and therefore not all violations are imported into GitHub's code scanning feature. Some violations get lost...

Running PMD through: GitHub Actions
@adangel adangel added the a:bug PMD crashes or fails to analyse a file. label Feb 10, 2022
@adangel adangel added this to the 6.43.0 milestone Feb 10, 2022
@adangel adangel mentioned this issue Feb 10, 2022
Closed
@adangel adangel self-assigned this Feb 17, 2022
@adangel adangel mentioned this issue Feb 17, 2022
Merged
4 tasks
adangel added a commit that referenced this issue Feb 25, 2022
@adangel
Merge pull request #3788 from
9a437b0 
adangel:issue-3768-sarif-multiple-locations

[core] Fix #3768 SARIF: report each violation as separate result #3788

* pr-3788:
  [core] Refactoring renderer tests
  [core] Fix SARIF formatter reporting multiple locations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adangel adangel

Labels
a:bug PMD crashes or fails to analyse a file.
Projects
None yet
Milestone
6.43.0
Development

Successfully merging a pull request may close this issue.

[core] Fix #3768 SARIF: report each violation as separate result adangel/pmd
1 participant
@adangel