Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang-test] Upgrade dokka maven plugin to 1.4.32 #3759

Closed
adangel opened this issue Feb 3, 2022 · 2 comments · Fixed by #3760
Closed

[lang-test] Upgrade dokka maven plugin to 1.4.32 #3759

adangel opened this issue Feb 3, 2022 · 2 comments · Fixed by #3760
Labels
in:pmd-internals Affects PMD's internals
Milestone

Comments

@adangel
Copy link
Member

adangel commented Feb 3, 2022

We currently need jcenter as a repository

pmd/pom.xml

Lines 931 to 943 in 1290999

<pluginRepository>
<!-- needed for dokka-maven-plugin in pmd-lang-test -->
<id>jcenter</id>
<name>JCenter</name>
<releases>
<enabled>true</enabled>
<updatePolicy>never</updatePolicy>
</releases>
<snapshots>
<enabled>false</enabled>
</snapshots>
<url>https://jcenter.bintray.com/</url>
</pluginRepository>

But jcenter is basically obsolete, although they keep it running as read-only (so that e.g. our build doesn't break): https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/ .
However, this created already a problem for reproducible builds (jvm-repo-rebuild/reproducible-central#70)

We currently use dokka 1.4.30.

It seems that upgrading to 1.4.32 is already sufficient, although this version still uses jcenter. At least I can build pmd with a fresh maven repo and without jcenter.

The new dokka version 1.6.10 only uses maven-central, but might require us to update kotlin etc.

@adangel adangel added the an:enhancement An improvement on existing features / rules label Feb 3, 2022
@adangel adangel added this to the 6.43.0 milestone Feb 3, 2022
@adangel adangel added in:pmd-internals Affects PMD's internals and removed an:enhancement An improvement on existing features / rules labels Feb 3, 2022
@adangel adangel changed the title [lang-test] Upgrade Dokka [lang-test] Upgrade dokka maven plugin to 1.4.32 Feb 3, 2022
@adangel
Copy link
Member Author

adangel commented Feb 4, 2022

Actually I wanted to update the kotlin version in this release... Should I do that early so that you can use the latest dokka 1.6.10?

I tested it with 1.4.32 and the update is unproblematic (see PR #3760). So there is no urgency required. The fix for the reproducible build is actually independent (it's just adding jcentral as a repo), but I wanted to take the chance to remove jcenter directly.

@oowekyala
Copy link
Member

Ok great! I found out about your PR after writing my comment, which made no sense given there's already a PR. Thanks for looking into this, it sounds like a nice fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:pmd-internals Affects PMD's internals
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants