[core] designer.bat errors when JAVAFX_HOME contains spaces

[zzzzfeng]

Affects PMD Version:

version 6.35.0
Windows

Description:

error code:
[%JAVAFX_HOME%] EQU []

runtime error:
if [C:\Program Files\javafx-sdk-11.0.2\] EQU [] (
此时不应有 Files\javafx-sdk-11.0.2\]。

fix:
["%JAVAFX_HOME%"] EQU [""]

[LY1806620741]

I have the same problem as you.
This bug exists in windows10, Because space symbol in Env variable.

pmd/pmd-dist/src/main/resources/scripts/designer.bat

Line 40 in 81739da

if [%JAVAFX_HOME%] EQU [] (

[adangel]

In this example:

> set JAVAFX_HOME="C:\Program Files\javafx-sdk-17.0.1"
> bin\designer.bat
Fehler: Hauptklasse Files\javafx-sdk-17.0.1\lib\* konnte nicht gefunden oder geladen werden
Ursache: java.lang.ClassNotFoundException: Files\javafx-sdk-17.0.1\lib\*

my error is a bit different: it can't find the main class - which means the command line for calling java is messed up.

Adding the suggested fix makes things worse:

"Files\javafx-sdk-17.0.1""]" kann syntaktisch an dieser Stelle nicht verarbeitet werden.

After reading http://windowsinspired.com/understanding-the-command-line-string-and-arguments-received-by-a-windows-program/ the problem is actually here:

pmd/pmd-dist/src/main/resources/scripts/designer.bat

Line 51 in 7173f65

java %PMD_JAVA_OPTS% %jreopts% -classpath "%classpath%" %OPTS% %MAIN_CLASS% %*

The quotes around "%classpath%" are wrong.