From 594ada60852f6f92a7e2ff8811f2f44bccad08ad Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Thu, 19 Jan 2023 10:59:28 -0500 Subject: [PATCH 1/2] fix for cartesian interact noCi test --- src/plots/cartesian/dragbox.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/plots/cartesian/dragbox.js b/src/plots/cartesian/dragbox.js index 1e4b889c15..29b9067070 100644 --- a/src/plots/cartesian/dragbox.js +++ b/src/plots/cartesian/dragbox.js @@ -729,7 +729,9 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) { function pushActiveAxIdsSynced(axList, axisType) { for(i = 0; i < axList.length; i++) { - if(!axList[i].fixedrange && axList[i][axisType]) {activeAxIds.push(axList[i][axisType]._id);} + var axListI = axList[i]; + var axListIType = axListI[axisType]; + if(!axListI.fixedrange && axListIType.tickmode === 'sync') activeAxIds.push(axListIType._id); } } From 0828681020164182824125bc8f2ed3ca4f80b114 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Thu, 19 Jan 2023 11:13:45 -0500 Subject: [PATCH 2/2] mention PR 6443 in the draft log --- draftlogs/6356_add.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/draftlogs/6356_add.md b/draftlogs/6356_add.md index 929da457d8..eb4281c478 100644 --- a/draftlogs/6356_add.md +++ b/draftlogs/6356_add.md @@ -1 +1 @@ -- Add `sync` tickmode option [[#6356](https://github.com/plotly/plotly.js/pull/6356)] \ No newline at end of file +- Add `sync` tickmode option [[#6356](https://github.com/plotly/plotly.js/pull/6356), [#6443](https://github.com/plotly/plotly.js/pull/6443)] \ No newline at end of file